-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ps protocol inner 349 #3861
Conversation
fix fix
void paramEofResponse(List<byte[]> params, byte[] eof, MySQLResponseService service); | ||
|
||
void fieldEofResponse(List<byte[]> fields, byte[] eof, MySQLResponseService service); | ||
void preparedExecuteResponse(byte[] header, List<byte[]> fields, byte[] eof, MySQLResponseService service); |
Check notice
Code scanning / CodeQL
Useless parameter Note
if (service.getSession() != null) { | ||
service.getSession().startExecuteBackend(service.getConnection().getId()); | ||
} | ||
switch (data[4]) { |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
data
this
boolean executeResponse = service.syncAndExecute(); | ||
if (executeResponse) { | ||
// Prepare ok | ||
byte type = data[4]; |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
data
this
} | ||
break; | ||
case RESULT_STATUS_HEADER: | ||
switch (data[4]) { |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
data
this
} | ||
break; | ||
case RESULT_STATUS_FIELD_EOF: | ||
switch (data[4]) { |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
data
this
private void closeNoHandler() { | ||
if (!service.getConnection().isClosed()) { | ||
service.getConnection().close("no handler"); | ||
LOGGER.info("no handler bind in this con " + this + " client:" + service); |
Check notice
Code scanning / CodeQL
Use of default toString() Note
this.cursor = cursor; | ||
} | ||
|
||
public void handleInnerData(byte[] data) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
MysqlBackendLogicHandler.handleInnerData
@@ -15,9 +15,7 @@ | |||
*/ | |||
public interface PreparedResponseHandler { | |||
|
|||
void preparedOkResponse(byte[] ok, MySQLResponseService service); | |||
void preparedOkResponse(byte[] ok, List<byte[]> fields, List<byte[]> params, MySQLResponseService service); |
Check notice
Code scanning / CodeQL
Useless parameter Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pick from #2402
Reason:
BUG #. or Improve #.
Type:
BUG/Improve
Influences:
fix xx