Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ps protocol inner 349 #3861

Merged
merged 1 commit into from
Feb 1, 2024
Merged

support ps protocol inner 349 #3861

merged 1 commit into from
Feb 1, 2024

Conversation

ylinzhu
Copy link
Member

@ylinzhu ylinzhu commented Feb 1, 2024

pick from #2402

Reason:
  BUG #. or Improve #.
Type:
  BUG/Improve
Influences:
   fix xx

@github-actions github-actions bot requested a review from LUAgam February 1, 2024 07:57
@ylinzhu ylinzhu requested review from wenyh1 and removed request for LUAgam February 1, 2024 07:58
void paramEofResponse(List<byte[]> params, byte[] eof, MySQLResponseService service);

void fieldEofResponse(List<byte[]> fields, byte[] eof, MySQLResponseService service);
void preparedExecuteResponse(byte[] header, List<byte[]> fields, byte[] eof, MySQLResponseService service);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'service' is never used.
if (service.getSession() != null) {
service.getSession().startExecuteBackend(service.getConnection().getId());
}
switch (data[4]) {

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
data
may be null at this access as suggested by
this
null guard.
boolean executeResponse = service.syncAndExecute();
if (executeResponse) {
// Prepare ok
byte type = data[4];

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
data
may be null at this access as suggested by
this
null guard.
}
break;
case RESULT_STATUS_HEADER:
switch (data[4]) {

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
data
may be null at this access as suggested by
this
null guard.
}
break;
case RESULT_STATUS_FIELD_EOF:
switch (data[4]) {

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
data
may be null at this access as suggested by
this
null guard.
private void closeNoHandler() {
if (!service.getConnection().isClosed()) {
service.getConnection().close("no handler");
LOGGER.info("no handler bind in this con " + this + " client:" + service);

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): MysqlExecuteResponseHandler inherits toString() from Object, and so is not suitable for printing.
this.cursor = cursor;
}

public void handleInnerData(byte[] data) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
MysqlBackendLogicHandler.handleInnerData
; it is advisable to add an Override annotation.
@@ -15,9 +15,7 @@
*/
public interface PreparedResponseHandler {

void preparedOkResponse(byte[] ok, MySQLResponseService service);
void preparedOkResponse(byte[] ok, List<byte[]> fields, List<byte[]> params, MySQLResponseService service);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'service' is never used.
Copy link
Member

@wenyh1 wenyh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ylinzhu ylinzhu merged commit 4fc9e40 into 3.20.10.99/lts Feb 1, 2024
4 checks passed
@ylinzhu ylinzhu deleted the 1111 branch February 1, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants