Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert chmod removal for v1 #68

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Revert chmod removal for v1 #68

merged 1 commit into from
Jul 10, 2023

Conversation

JamesMGreene
Copy link
Contributor

Temporarily revert PR:

It represents a breaking change that we should move into a v2.0.0 release.

Context: an accurate criticism from user @onbjerg in the deploy-pages action repo:

...although I feel like this should have been a breaking version bump on @actions/upload-pages-artifact? 😄

@JamesMGreene
Revert PR #63
75e09bd 
It represents a breaking change that we should move into a v2.0.0 release
@JamesMGreene JamesMGreene requested a review from a team as a code owner July 10, 2023 16:03
@JamesMGreene JamesMGreene mentioned this pull request Jul 10, 2023
Merged
@JamesMGreene JamesMGreene merged commit 81e1caf into main Jul 10, 2023
@JamesMGreene JamesMGreene deleted the revert-chmod-for-v1 branch July 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsusdere tsusdere tsusdere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesMGreene @tsusdere