Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly resolve relative symlinks #1844

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Properly resolve relative symlinks #1844

merged 2 commits into from
Oct 8, 2024

Conversation

robherley
Copy link
Contributor

@robherley robherley commented Oct 8, 2024 •
edited
Loading

After adding custom symlink logic in:

We did not resolve relative symlinks properly with readlink, we should have been using realpath to resolve. Also updated tests to better capture this case.

Reported in:

@robherley robherley requested a review from a team as a code owner October 8, 2024 16:38
@robherley robherley mentioned this pull request Oct 8, 2024
Closed
@robherley robherley merged commit 201b082 into main Oct 8, 2024
14 checks passed
@robherley robherley mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmgross joshmgross joshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robherley @joshmgross