Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sha256 instead of md5 for artifact v4 integrity hash #1563

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Use sha256 instead of md5 for artifact v4 integrity hash #1563

merged 2 commits into from
Oct 16, 2023

Conversation

robherley
Copy link
Contributor

Recent MSFT guidance is to not use MD5, even for integrity. This updates the upload response to use SHA256 instead.

Related:

@robherley robherley requested a review from a team as a code owner October 16, 2023 16:22
@robherley robherley marked this pull request as draft October 16, 2023 16:23
@robherley robherley marked this pull request as ready for review October 16, 2023 16:50
@robherley robherley requested a review from a team as a code owner October 16, 2023 16:50
@robherley robherley merged commit fe3e7ce into main Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
@Shurikenttt
Copy link

  • name: Tar files
    run: tar -cvf my_files.tar /path/to/my/directory

  • name: Upload Artifact
    uses: actions/upload-artifact@v3
    with:
    name: my-artifact
    path: my_files.tar

@Gitanito333
Copy link

packages/artifact/src/internal/upload/blob-upload.ts

1 similar comment
@Gitanito333
Copy link

packages/artifact/src/internal/upload/blob-upload.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacaovsnc yacaovsnc yacaovsnc approved these changes

@konradpabjan konradpabjan konradpabjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robherley @Shurikenttt @Gitanito333 @yacaovsnc @konradpabjan