Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): getMultilineInput not trimming whitespace #1185

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(core): getMultilineInput not trimming whitespace #1185

merged 1 commit into from
Sep 28, 2022

Conversation

bicstone
Copy link
Contributor

@bicstone bicstone commented Sep 28, 2022 •
edited
Loading

Fixed #1186

core.getInput is trimming whitespace by default, but core.getMultilineInput is not.
Also, core.getMultilineInput ignores trimWhitespace option.

This pull request has been fixed so that core.getMultilineInput will trim whitespace in the same way as core.getInput.

@bicstone bicstone requested a review from a team as a code owner September 28, 2022 04:01
@bicstone bicstone mentioned this pull request Sep 28, 2022
Closed
@bicstone bicstone changed the title fix(core): getMultilineInput not trimming whitespace fix(core): getMultilineInput not trimming whitespace Sep 28, 2022
rentziass
rentziass approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@rentziass rentziass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this! Looking good to me, merging 🚀

@rentziass rentziass merged commit 4df4517 into actions:main Sep 28, 2022
@rentziass rentziass mentioned this pull request Sep 29, 2022
Merged
@bicstone bicstone mentioned this pull request Oct 17, 2022
Merged
@warnyul warnyul mentioned this pull request Jan 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rentziass rentziass rentziass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: getMultilineInput not trimming whitespace
2 participants
@bicstone @rentziass