set node-version output #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaksimZhukov @dmitry-shibanov is this something you may look into? |
|
This would be nice!
But now with |
samhed
referenced
this pull request
in novnc/noVNC
Oct 22, 2021
Apparently the new eslint version doesn't work with the older version of node that we were using. Asking for '@v2' seems to help. It's unclear what version of node we get now though since v2 isn't as verbose in its output.
Muncikas
approved these changes
Oct 23, 2021
|
Can we get some movement on reviewing this PR? This output is needed to make a better cache key (invalidate when minor version increases.) |
|
ping @0xdeafcafe @dmitry-shibanov, would any of you be able to review/merge this? |
0xdeafcafe
approved these changes
Nov 25, 2021
|
I would love to merge, but I'm not a project owner @LinusU 😅 |
|
@dmitry-shibanov @MaksimZhukov going by the upvotes this is a sought after feature. |
Mmkred
approved these changes
Dec 30, 2021
|
ping @dmitry-shibanov, any chance of landing this? |
|
Coming up on 2 years now with no feedback what so ever, please land it, close it, or ask for changes. 🙏 |
2 tasks
|
Superseded by #534 |
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
Bumps [eslint](https://github.com/eslint/eslint) from 7.23.0 to 7.24.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.23.0...v7.24.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
node-versionto the action output.closes #150