Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for major release selection #32

Closed
wants to merge 1 commit into from
Closed

Add support for major release selection #32

wants to merge 1 commit into from

Conversation

tie
Copy link

@tie tie commented Dec 14, 2019 •
edited
Loading

This PR adds 'latest' version alias that resolves to the latest available release.

The getPossibleVersions function filters using startsWith(version), so calling getLatestVersion(version) with an empty string will return the latest release.

Closes #31.

zikaeroh
zikaeroh reviewed Dec 14, 2019
View reviewed changes
@zikaeroh
Copy link

Thanks for removing the tip stuff. Can you modify your PR message now that tip isn't included to better reflect the change? I wouldn't want this to be merged and close the wrong issue (or mention things the PR no longer does).

Another suggestion would be to allow an unset go-version to imply latest (for lazy users who don't care), but I'm not sure how good of an idea that is when the builders already include some version of Go (and it's better for build pipelines to be consistent-ish, where picking 1.13.x would be better than saying nothing).

@tie
Copy link
Author

tie commented Dec 14, 2019

Updated PR message to reflect the change.

@tie
Add support for major release selection
dcc7425 
This commit adds 'latest' version alias that resolves to the
latest available release.

The getPossibleVersions function filters available releases using
startsWith(version), so calling getLatestVersion(version) with an
empty string will return the latest release.

Closes #31
@tie
Copy link
Author

tie commented Dec 14, 2019 •
edited
Loading

Updated commit message too.

@tie tie mentioned this pull request Dec 18, 2019
Closed
@bryanmacfarlane
Copy link
Member

With the new v2-beta rewrite, should this just be 1.* . (that supports semver ranges)

@bryanmacfarlane
Copy link
Member

See comment ☝️

@jaqx0r jaqx0r mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zikaeroh zikaeroh zikaeroh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the latest release
3 participants
@tie @zikaeroh @bryanmacfarlane