Set GOPATH to the default directory if unset

[crazy-max]

This PR should fix issues linked to GOPATH definition (#12 #14).
TravisCI also has pretty much this behavior while initializing Go with gimme and the official Go Docker image too.

[kjk]

FYI: looks like you've inadvertently changed the line endings of the files, so unless the diff is told to ignore whitespace changes it's hard to tell what changed.

[crazy-max]

@kjk Yeah looks like tsc fucked up ^^
Scroll down to TS definition to look at my changes

Edit: Should be fine now

[crazy-max]

@damccorm Some feedback on this ?

[bryanmacfarlane]

Feedback:

• the diff needs to be cleaned up so it's just what's changed. You may want to re-fork or something. I just did a massive rewrite and master is v2-beta and v1 is in releases/v1. If we do this, then v2 only.
• I don't think this is the right thing to do for everyone. I think there should be a bool input whether to setGoPath and it should default to false. There's post 1.13 scenarios with modules where you absolutely don't want to do this and those scenarios are becoming more and more common as folks adopt modules which must have your code outside of GOPATH.
• because of points above, I wonder whether we should do this. As time goes on, the feature is less needed.

[bryanmacfarlane]

also, do an npm run pre-checkin which will reformat. Set line endings to auto. are you coding on windows?

[crazy-max]

@bryanmacfarlane

because of points above, I wonder whether we should do this. As time goes on, the feature is less needed.

Agree to close this issue looking at those points.

also, do an npm run pre-checkin which will reformat. Set line endings to auto. are you coding on windows?

Yeah I'm currently on Windows but will move back to Linux in few hours ;)

[bryanmacfarlane]

I might also set some repo level git line level ending settings ...