Implement proposal stated in ADR for setup-dotnet v3 and functionality from feature request #219 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 14, 2022 12:34
In the scope of this commit such functionalty was added: 1. Installation directories for Windows and Ubuntu were changed to the folder with preinstalled .NET SDK's 2. Inner logic of interaction with MS dotnet installer scripts was changed 3. New input "dotnet-quality" was added Such functionality was cut out: 1. Input "include-prerelease"
IvanZosimov
requested review from
vsafonkin,
panticmilos,
e-korolevskii,
dmitry-shibanov,
dsame and
marko-zivic-93
2 tasks
e-korolevskii
approved these changes
Sep 14, 2022
marko-zivic-93
approved these changes
Sep 15, 2022
panticmilos
approved these changes
Sep 15, 2022
panticmilos
reviewed
Sep 15, 2022
vsafonkin
approved these changes
Sep 19, 2022
marko-zivic-93
approved these changes
Sep 20, 2022
IvanZosimov
force-pushed
the
ADRdotnet
branch
from
d2366de to
1d59406
Compare
dmitry-shibanov
approved these changes
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
reviewed
Sep 21, 2022
brcrista
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the scope of this PR such changes were made:
dotnet-qualitywas addedsetup-dotnetby default is able to install a prerelease version of SDK (preview, rc) if it's the latest on the channel (equivalent to setting v2's 'include-prerelease' input to true).This PR also solves this issue: #251
Related issue:
https://github.com/actions/runner-images-internal/issues/4058
https://github.com/actions/runner-images-internal/issues/4059
https://github.com/actions/runner-images-internal/issues/4060
#219
Check list: