[windows] split docker install into 3 scripts #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the idea is to end with 1 script per 1 component for better observability
Co-authored-by: Erik Bershel <[email protected]>
Co-authored-by: Vasilii Polikarpov <[email protected]>
…/runner-images into feat_split_docker_install
vpolikarpov-akvelon
approved these changes
Nov 2, 2023
ilia-shipitsin
added
CI windows-2019
CI windows-2022
and removed
CI windows-2019
CI windows-2022
labels
mikhailkoliada
approved these changes
Nov 6, 2023
mikhailkoliada
added a commit
that referenced
this pull request
Nov 8, 2023
* Update folder structure * Adjust packer templates and debug * Fix issues in ubuntu2204 template * Remove Debug steps * Rename template, sync pipelines and adjust resource gen script * fix post-gen path in ubuntu-minimal * fix shebang linter, workflow paths and adjust readme * update preimagedata * [MacOS] Add xcode 15.0.1 (#8604) * Updating readme file for macos-13 version 20231018.14 (#8601) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for macos-13-arm64 version 20231017.1 (#8586) Co-authored-by: Image generation service account <[email protected]> * [MacOS] improve errexit option handling (#8432) * [MacOS] improve errexit option handling * Prevent prompting for override when unzipping * Explicitly allow failing when installing virtualbox * Remove libtcl symlinks * Add debug output * Updating readme file for ubuntu20 version 20231022.1.1 (#8637) Co-authored-by: Image generation service account <[email protected]> * Updating readme file for ubuntu22 version 20231022.1.1 (#8636) Co-authored-by: Image generation service account <[email protected]> * Updating readme file for win19 version 20231023.1.1 (#8644) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for win22 version 20231023.1.1 (#8643) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * [macos] simplify "brew_smart_install" helper (#8639) * [macos] homebrew: use hardcoded condition for jq installation we cannot use "jq" if we are asked to install "jq" * [macos] always use "brew install" * [macos] add retries to "get_github_package_download_url" helper * [macos] add retries to chrome install script * [macos] add retries to OpenJDK install script * [macos] add retries to miniconda installer * Update images/macos/provision/core/openjdk.sh Co-authored-by: Vasilii Polikarpov <[email protected]> * fix copy-paste error * Update images/macos/provision/core/openjdk.sh Co-authored-by: Vasilii Polikarpov <[email protected]> * Update images/macos/provision/core/openjdk.sh Co-authored-by: Vasilii Polikarpov <[email protected]> --------- Co-authored-by: Vasilii Polikarpov <[email protected]> * Updating readme file for ubuntu22 version 20231025.1.1 (#8663) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for ubuntu20 version 20231025.1.1 (#8664) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for win22 version 20231024.1.1 (#8668) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Windows Server 2019 (20231025) Image Update (#8667) * Updating readme file for win19 version 20231025.2.1 * Update Windows2019-Readme.md --------- Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Mikhail Koliada <[email protected]> Co-authored-by: Actions service account <[email protected]> * [Mac OS] Fix logic for retrying AppleScript execution (#8662) * [Ubuntu] Add PGP validation for swift (#8652) * [Windows] Remove out-of-support vs components (#8678) * [MacOS] Unpin Virtualbox (#8653) * [MacOS] Unpin Virtualbox * Remove obsolete virtualbox kext pester test * [Ubuntu] Update apt repos list in documentation (#8634) * fix: bump libssl version to ubuntu2.20 (#8682) Signed-off-by: Jakub Oskera <[email protected]> Co-authored-by: Jakub Oskera <[email protected]> * [macOS] increase timeout for the macOS ci (#8692) * Updating readme file for macos-13-arm64 version 20231024.2 (#8673) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Escape quotes when running in PowerShell 7.0-7.2 (#8705) * fix: checksum search for Kotlin (#8704) * [Ubuntu] Fix checksum search for Kotlin * [Windows] Fixed checksum search for Kotlin * [Ubuntu] Pin bindgen cli version to avoid bug (#8714) * [Ubuntu] Add more checksum validations (#8660) * [Windows] Pin bindgen cli version to avoid bug (#8713) * Updating readme file for ubuntu22 version 20231030.2.1 (#8691) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for ubuntu20 version 20231030.2.1 (#8690) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for win19 version 20231029.1.1 (#8687) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Revert "[Windows] Pin bindgen cli version to avoid bug (#8713)" (#8719) This reverts commit 1dac9b9. * Revert "[Ubuntu] Pin bindgen cli version to avoid bug (#8714)" (#8720) This reverts commit 3146c70. * [Mac OS] Temporary disable VNC for Mac OS 14 (#8717) * Updating readme file for win22 version 20231029.1.1 (#8686) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * Updating readme file for macOS-11 version 20231030.1 (#8694) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * [Mac OS] Add template for Mac OS 14 image (#8733) * Add gfortran-13 (#8702) * Revert "[MacOS] Unpin Virtualbox" (#8731) * Revert "[MacOS] Unpin Virtualbox (#8653)" This reverts commit f3d011e. * Add more info * [ubuntu] split git and git-lfs into separate install scripts (#8711) for better observability of integrity validation let us split install script into two * Updating readme file for macOS-12 version 20231029.1 (#8695) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * [Windows] Remove Android SDK Patch applier v4 (#8750) * remove ndk 23 from macos images (#8747) * [Mac OS] Remove 'LTS' suffix from OpenJDK version (#8751) * [windows] split docker install into 3 scripts (#8688) * [windows] split docker install into 3 scripts the idea is to end with 1 script per 1 component for better observability * Update images/win/scripts/Installers/Install-Docker-Compose.ps1 Co-authored-by: Erik Bershel <[email protected]> * Update images/win/scripts/Installers/Install-Docker-WinCred.ps1 Co-authored-by: Vasilii Polikarpov <[email protected]> * fix test --------- Co-authored-by: Erik Bershel <[email protected]> Co-authored-by: Vasilii Polikarpov <[email protected]> * remove ndk 23 from ubuntu images (#8745) * [macos] add android SDK to SW report on Ventura ARM64 (#8715) * [Mac OS] Update Anka Helpers to build Mac OS 14 ARM image (#8757) * Update Anka Helpers to build Mac OS 14 ARM image * Drop Powershell 5 support * [Mac OS] Add missing macOS Sonoma selector (#8759) * remove ndk23 from windows images (#8746) * Updating readme file for macos-13 version 20231025.2 (#8672) Co-authored-by: Image generation service account <[email protected]> --------- Signed-off-by: Jakub Oskera <[email protected]> Co-authored-by: sergei-pyshnoi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> Co-authored-by: Vasilii Polikarpov <[email protected]> Co-authored-by: ilia-shipitsin <[email protected]> Co-authored-by: Mikhail Koliada <[email protected]> Co-authored-by: Jakub Oskera <[email protected]> Co-authored-by: Jakub Oskera <[email protected]> Co-authored-by: Luke Fritts <[email protected]> Co-authored-by: Erik Bershel <[email protected]> Co-authored-by: Harmen Stoppels <[email protected]>
mikhailkoliada
pushed a commit
that referenced
this pull request
Nov 9, 2023
* New folder structure * Update packer templates * Update refs in scripts * Updating readme file for macOS-12 version 20231029.1 (#8695) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> * [Windows] Remove Android SDK Patch applier v4 (#8750) * remove ndk 23 from macos images (#8747) * [Mac OS] Remove 'LTS' suffix from OpenJDK version (#8751) * [windows] split docker install into 3 scripts (#8688) * [windows] split docker install into 3 scripts the idea is to end with 1 script per 1 component for better observability * Update images/win/scripts/Installers/Install-Docker-Compose.ps1 Co-authored-by: Erik Bershel <[email protected]> * Update images/win/scripts/Installers/Install-Docker-WinCred.ps1 Co-authored-by: Vasilii Polikarpov <[email protected]> * fix test --------- Co-authored-by: Erik Bershel <[email protected]> Co-authored-by: Vasilii Polikarpov <[email protected]> * remove ndk 23 from ubuntu images (#8745) * [macos] add android SDK to SW report on Ventura ARM64 (#8715) * Fix utils path in templates * Sync changes * [Mac OS] Update Anka Helpers to build Mac OS 14 ARM image (#8757) * Update Anka Helpers to build Mac OS 14 ARM image * Drop Powershell 5 support * [Mac OS] Add missing macOS Sonoma selector (#8759) * remove ndk23 from windows images (#8746) * Updating readme file for macos-13 version 20231025.2 (#8672) Co-authored-by: Image generation service account <[email protected]> * Fix macOS-12.anka template with assets path --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]> Co-authored-by: Erik Bershel <[email protected]> Co-authored-by: sergei-pyshnoi <[email protected]> Co-authored-by: Vasilii Polikarpov <[email protected]> Co-authored-by: ilia-shipitsin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the idea is to end with 1 script per 1 component for better observability
Related issue:
https://github.com/github/c2c-actions-akvelon/issues/38
Check list