Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boost windows documentation section to add toolset and Cmake notes, remove BOOST_ROOT variable #540

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Update boost windows documentation section to add toolset and Cmake notes, remove BOOST_ROOT variable #540

merged 3 commits into from
Mar 17, 2020

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Mar 11, 2020

Customer request:

  1. Update Boost Toolset
  2. Update CMake FindBoost behavior

Updates:

  1. Add a toolset name what was used at the building boost pre-cache artifact.
  2. Add CMake FindBoost section to describe new function behavior from Boost 1.70.0
  3. Remove BOOST_ROOT env variable (Environment variable BOOST_ROOT will be deprecated in 2 month.  #319)

Example output:

Boost

1.69.0 [msvc-14.1]

Environment:

  • BOOST_ROOT_1_69_0: root directory of the Boost version 1.69.0 installation

1.72.0 [msvc-14.2]

Environment:

  • PATH: contains the location of Boost version 1.72.0
  • BOOST_ROOT_1_72_0: root directory of the Boost version 1.72.0 installation

Notes:

Link: https://cmake.org/cmake/help/latest/module/FindBoost.html

If Boost was built using the boost-cmake project or from Boost 1.70.0 on it provides a package
configuration file for use with find_package's config mode. This module looks for the package
configuration file called BoostConfig.cmake or boost-config.cmake and stores the result in CACHE entry "Boost_DIR".
If found, the package configuration file is loaded and this module returns with no further action.
See documentation of the Boost CMake package configuration for details on what it provides.

Set Boost_NO_BOOST_CMAKE to ON, to disable the search for boost-cmake.

@al-cheb al-cheb changed the title Update boost toolset and notes in windows documentation Update boost windows documentation section to add toolset and Cmake notes Mar 11, 2020
Copy link
Contributor

@alepauly alepauly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @al-cheb !

@traversaro
Copy link

traversaro commented Mar 15, 2020

I thought that (according to #319) the BOOST_ROOT enviroment variable was deprecated, but this PR seems to document its usage on Windows platform.

@al-cheb al-cheb changed the title Update boost windows documentation section to add toolset and Cmake notes Update boost windows documentation section to add toolset and Cmake notes, deprecate BOOST_ROOT variable Mar 16, 2020
@al-cheb al-cheb changed the title Update boost windows documentation section to add toolset and Cmake notes, deprecate BOOST_ROOT variable Update boost windows documentation section to add toolset and Cmake notes, remove BOOST_ROOT variable Mar 16, 2020
@al-cheb al-cheb requested a review from maxim-lobanov March 16, 2020 20:44
@maxim-lobanov maxim-lobanov merged commit eff9858 into actions:master Mar 17, 2020
erenon added a commit to morganstanley/binlog that referenced this pull request Mar 30, 2020
erenon added a commit to morganstanley/binlog that referenced this pull request Apr 3, 2020
erenon added a commit to morganstanley/binlog that referenced this pull request Apr 5, 2020
@erenon erenon mentioned this pull request Apr 9, 2020
5 tasks
lazka added a commit to lazka/meson that referenced this pull request Sep 23, 2022
This was initially added in eb76ba7 to avoid picking
it up from azure/gha images.

Looks like it is no longer set for some time now though:
actions/runner-images#540
so should no longer be needed.

The empty string makes some meson tests fail which expect a path.
A recent msys2-runtime change now lets empty env vars through to child processes
whereas before they would get filtered out, which is why this worked before.
xclaesse pushed a commit to mesonbuild/meson that referenced this pull request Sep 23, 2022
This was initially added in eb76ba7 to avoid picking
it up from azure/gha images.

Looks like it is no longer set for some time now though:
actions/runner-images#540
so should no longer be needed.

The empty string makes some meson tests fail which expect a path.
A recent msys2-runtime change now lets empty env vars through to child processes
whereas before they would get filtered out, which is why this worked before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants