Install ghcup on windows #4044
Merged
Install ghcup on windows #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-cheb
reviewed
Sep 8, 2021
| @@ -33,3 +33,7 @@ Write-Host 'Installing cabal...' | |||
| Choco-Install -PackageName cabal | |||
|
|
|||
| Invoke-PesterTests -TestFile 'Haskell' | |||
|
|
|||
| # install minimal ghcup, utilizing pre-installed msys2 at C:\msys64 | |||
There was a problem hiding this comment.
nitpick: I think we should split this command.
$bootstrapHaskell = Invoke-WebRequest https://www.haskell.org/ghcup/sh/bootstrap-haskell.ps1 -UseBasicParsing
Invoke-Command -ScriptBlock ([ScriptBlock]::Create($bootstrapHaskell)) -ArgumentList $false, $true, $true, $false, $false, $false, $false, C:\, "", C:\msys64, C:\cabal
hasufell
force-pushed
the
hasufell/PR/ghcup-windows
branch
from
5a1d02c to
3466491
Compare
|
/azp run windows2016, windows2019, windows2022 |
|
Azure Pipelines successfully started running 3 pipeline(s). |
miketimofeev
approved these changes
Sep 10, 2021
al-cheb
approved these changes
Sep 10, 2021
|
@hasufell thanks for your contribution! The changes will be available next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4016 for discussion and reasoning.
This just adds ghcup the binary to the installation. It still uses chocolatey for installation. I leave it open for discussion whether chocolatey or ghcup should be used. However, there have been some reports of chocolatey issues: haskell/actions#70 (comment)
I can't comment on the nature of them. I believe chocolatey is quite robust. It lacks a little bit behind in adding new GHC versions, but not significantly.
The main (or maybe only) difference between ghcup and chocolatey is the shimgen wrapper they use for emulating symlinks to
ghc.exe:Which one of those makes less problems, I don't know.