Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All OSes] Go 1.17.x will be removed and 1.20.x set as default on April, 3 #7276

Closed
8 of 9 tasks
mikhailkoliada opened this issue Mar 13, 2023 · 3 comments
Closed
8 of 9 tasks
Assignees
Labels
Announcement Area: Go awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: macOS OS: Ubuntu OS: Windows

Comments

@mikhailkoliada
Copy link
Contributor

Breaking changes

Go 1.17.x will be removed from all OSes and 1.20.x will be set as default.

Target date

Image deployment is starting on April 3 and will take 3-4 days.

The motivation for the changes

As of the software support policy only 3 latest versions of Go are supported.

Possible impact

If your builds depend on Go 1.17.x they can be broken.

Platforms affected

  • Azure DevOps
  • GitHub Actions

Runner images affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • Windows Server 2019
  • Windows Server 2022

Mitigation ways

To install any versions in runtime use:

https://github.com/actions/setup-go action for GH actions
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/go-tool?view=azure-devops task for AzDO

@ilia-shipitsin ilia-shipitsin mentioned this issue Mar 15, 2023
11 tasks
@mikhailkoliada mikhailkoliada pinned this issue Mar 17, 2023
ilia-shipitsin added a commit to ilia-shipitsin/runner-images that referenced this issue Mar 27, 2023
Related: actions#7276

As of the software policy only 3 latest versions of Go are supported.
Go 1.17 is removed from images, 1.20 is now default Go version.
ilia-shipitsin added a commit to ilia-shipitsin/runner-images that referenced this issue Mar 27, 2023
Related: actions#7276

As of the software policy only 3 latest versions of Go are supported.
Go 1.17 is removed from images, 1.20 is now default Go version.
ilia-shipitsin added a commit to ilia-shipitsin/runner-images that referenced this issue Mar 27, 2023
Related: actions#7276

As of the software policy only 3 latest versions of Go are supported.
Go 1.17 is removed from images, 1.20 is now default Go version.
ilia-shipitsin added a commit to ilia-shipitsin/runner-images that referenced this issue Mar 27, 2023
Related: actions#7276

As of the software policy only 3 latest versions of Go are supported.
Go 1.17 is removed from images, 1.20 is now default Go version.
@actions actions deleted a comment Mar 28, 2023
@mikhailkoliada mikhailkoliada added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Mar 29, 2023
@mikhailkoliada
Copy link
Contributor Author

All was set, will be deployed next week

DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
`go get gotestfmt` isn't getting gotestfmt in a way that the CI jobs can
see. Something to do with
actions/runner-images#7276 maybe?

I think this might help with that.
DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
This was my first attempt to fix CI. Go 1.17 is no longer available on
runners (actions/runner-images#7276 maybe)
and I wondered if that might help with that.

Unfortunately I think not. But we should get some go build caching as a
side effect of using this action.
DMRobertson pushed a commit to matrix-org/synapse that referenced this issue Apr 6, 2023
DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
* Use setup-go action

This was my first attempt to fix CI. Go 1.17 is no longer available on
runners (actions/runner-images#7276 maybe)
and I wondered if that might help with that.

Unfortunately I think not. But we should get some go build caching as a
side effect of using this action.

* Bump checkout action

Drive-by fix for matrix-org/synapse#14203

* Check that gotestfmt is installed

no `-version` flag, so `help` will have to do

* `go install gotestfmt` instead of `go get`

IDK why this suddenly started failing, but `go install` seems to put it
on the PATH in a way that makes CI work.
DMRobertson pushed a commit to matrix-org/synapse that referenced this issue Apr 6, 2023
DMRobertson pushed a commit to matrix-org/synapse that referenced this issue Apr 6, 2023
* Use setup-go instead of relying on 1.17 to exist

See actions/runner-images#7276

* Changelog
@mikhailkoliada
Copy link
Contributor Author

Deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Announcement Area: Go awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: macOS OS: Ubuntu OS: Windows
Projects
None yet
Development

No branches or pull requests

3 participants
@mikhailkoliada @ilia-shipitsin and others