Environment variables: Add ImageOS companion to ImageVersion #345
Assignees
Comments
|
Hello, @MSP-Greg To double check am i right it should be?
|
|
Thanks. Yes, that is what I intended. Not sure about whether macOS needs any numeric suffix. If so, maybe macOS10.15 or macOS1015 ? |
al-cheb
added
awaiting-deployment
|
Hello, @MSP-Greg |
miketimofeev
removed
the
awaiting-deployment
2 tasks
bryannaegele
added a commit
to bryannaegele/act
that referenced
this issue
Jul 25, 2021
The current algorithm given `ubuntu-18.04` returns `ubuntu18.04` when it should be `ubuntu18` according to actions/runner-images#345 (comment).
bravo-kernel
added a commit
to bravo-kernel/Actions
that referenced
this issue
May 26, 2022
Changing the order of unique cache key generation to use `ImageOS` first so that matrix builds with e.g. multiple Linux versions do not break with below error message: ``` Unable to reserve cache with key Linux-psmodules-317DB88EFAFF4D1D0B5F92BF073201DA3F4083D92F59F60940FB05FABF623E14, another job may be creating this cache. ``` Reason: - action currently generates a cache using "Linux" as the unique identifier - this can sometimes lead to above error [as can be seen here](https://github.com/alt3/Docusaurus.Powershell/actions/runs/2389833954) (with two ubuntus using the same `Linux` cache key) - using ImageOS should fix this as it would use e.g. `ubuntu16` and `ubuntu18`, [as explained here](actions/runner-images#345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This request is suggested as a means of simplifying the inputs needed to some actions.
In https://github.com/actions/virtual-environments/tags, new images are tagged as below:
ImageVersion is the second part of the tag. Having the first part of the tag ('OS String') set to an environment variable ImageOS would be helpful. As to macOS, maybe just that?
One use is building separate packages/binaries for use on all platforms. Obviously, one can use 'runs-on:' or '${{ matrix.os }}' as an action input, but having the image name as an env variable would be simpler...
Note: submitted to 'GitHub Community Forums', which was then closed with the suggestion to post to Feedback form for GitHub Actions, which I did. I thought an issue might result in feedback/discussion...
The text was updated successfully, but these errors were encountered: