Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check artifact size and warn if too large #177

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

GretaP
Copy link
Contributor

@GretaP GretaP commented May 22, 2023

Closes #164

Uses internal endpoint to get the artifact size, and warns if it is above our limit.

@JamesMGreene JamesMGreene marked this pull request as ready for review June 6, 2023 14:40
@JamesMGreene JamesMGreene requested a review from a team as a code owner June 6, 2023 14:40
JamesMGreene
JamesMGreene previously approved these changes Jun 6, 2023
Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the warning message wording just a bit, but otherwise looks great to me. I also verified the changes did not break any of our regression testing repositories.

@JamesMGreene JamesMGreene merged commit dc213a7 into main Jun 6, 2023
@JamesMGreene JamesMGreene deleted the artifact-size branch June 6, 2023 14:47
@JamesMGreene
Copy link
Contributor

Verified:
warning-present-in-logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show warning if Pages artifact size is greater than 1 GB
2 participants