Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Get Pages failed" error message more helpful #83

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Make "Get Pages failed" error message more helpful #83

merged 3 commits into from
Apr 16, 2023

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Mar 25, 2023 •
edited
Loading

I was setting up gh-pages deployment as a GitHub action from the very beginning, and the error was confusing.

@WofWca WofWca requested a review from a team as a code owner March 25, 2023 14:57
@JamesMGreene
Copy link
Contributor

👋🏻 Just wanted to drop a quick note to say that I see your PR, and I appreciate it and its intent. 🙇🏻

That said, I do want to hold off on it until I get a chance to test this experience more thoroughly, as I'm a bit confused as to the specific configuration that must've been in place to trigger this error.

Did you perhaps run the workflow before enabling Pages at the repository level? 🤔

@WofWca
Copy link
Contributor Author

WofWca commented Mar 30, 2023

Did you perhaps run the workflow before enabling Pages at the repository level?

Well, yes. I made a fork of a repo (that didn't have GitHub Pages) and went straight for creating the GitHub action, without doing anything else, without going to settings or deploying the gh-pages branch manually.

@JamesMGreene
Copy link
Contributor

@WofWca Gotcha! Thanks for helping me understand the setup. 🙇🏻

@JamesMGreene JamesMGreene merged commit 5549504 into actions:main Apr 16, 2023
@JamesMGreene
Copy link
Contributor

This has been released in the latest version:

uses: actions/configure-pages@f156874f8191504dae5b037505266ed5dda6c382
uses: actions/[email protected]
uses: actions/configure-pages@v3
uses: actions/configure-pages@main

@JamesMGreene
Copy link
Contributor

Thanks again for the PR, @WofWca! That error message will definitely help some folks avoid this confusion in the future. 💝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMGreene JamesMGreene JamesMGreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WofWca @JamesMGreene