Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record a reason for pod failure in EphemeralRunner #3074

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Nov 15, 2023

Users can see why pods failed.

Relate: #2888

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Nov 17, 2023
Signed-off-by: utam0k <[email protected]>
@utam0k utam0k changed the title Record a reason for pod creation failure in EphemeralRunner Record a reason for pod failure in EphemeralRunner Nov 19, 2023
@utam0k utam0k requested a review from nikola-jokic November 19, 2023 22:34
@utam0k
Copy link
Contributor Author

utam0k commented Nov 21, 2023

@nikola-jokic Could you review this again? 🙏

Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@nikola-jokic nikola-jokic merged commit 7793e19 into actions:master Nov 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants