Release v1.0.1

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.1] - 2019-09-27
+
+### Fixed
+
+- Successful check without any warnings or errors was not terminated properly
+
 ## [1.0.0] - 2019-09-27
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
     "name": "rust-clippy-check",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "private": false,
     "description": "Run clippy and annotate the diff with errors and warnings",
     "main": "lib/main.js",

src/check.ts

@@ -100,7 +100,11 @@ ${this.stats.help} help`);
             userAgent: USER_AGENT,
         });
         const checkRunId = await this.createCheck(client, options);
-        await this.runUpdateCheck(client, checkRunId, options);
+        if (this.isSuccessCheck()) {
+            await this.successCheck(client, checkRunId, options);
+        } else {
+            await this.runUpdateCheck(client, checkRunId, options);
+        }
 
         return;
     }
@@ -159,6 +163,28 @@ ${this.stats.help} help`);
         return;
     }
 
+    private async successCheck(client, checkRunId: number, options: CheckOptions): Promise<void> {
+        let req: any = {
+            owner: options.owner,
+            repo: options.repo,
+            name: options.name,
+            check_run_id: checkRunId,
+            status: 'completed',
+            conclusion: this.getConclusion(),
+            completed_at: new Date().toISOString(),
+            output: {
+                title: options.name,
+                summary: this.getSummary(),
+                text: this.getText(options.context),
+            }
+        };
+
+        // TODO: Check for errors
+        await client.checks.update(req);
+
+        return;
+    }
+
     private getBucket(): Array<octokit.ChecksCreateParamsOutputAnnotations> {
         // TODO: Use slice or smth?
         let annotations: Array<octokit.ChecksCreateParamsOutputAnnotations> = [];
@@ -223,6 +249,11 @@ ${this.stats.help} help`);
         }
     }
 
+    private isSuccessCheck(): boolean {
+        return this.stats.ice == 0 && this.stats.error == 0 && this.stats.warning == 0 &&
+            this.stats.note == 0 && this.stats.help == 0;
+    }
+
     /// Convert parsed JSON line into the GH annotation object
     ///
     /// https://developer.github.com/v3/checks/runs/#annotations-object