Filter PMP by stage. #94 #95
Conversation
| if (!showExisting && stage == "Existing") { | ||
| return false; | ||
| } | ||
| if (!showDesign && stage == "Design") { |
There was a problem hiding this comment.
I think we also need a check if it is existing and ! resolved by design
(!showDesign && (stage == "Design" || (stage == "Existing" && !resolvedByDesign))
There was a problem hiding this comment.
Do we want a third checkbox for "Show resolved issues", or is this implied somehow? I understood the issue as just wanting to filter by stage.
There was a problem hiding this comment.
Sure but my thinking is: filtering by stage it exists at.
If something exists already, and is not resolved by design then it exists in both design stage and existing stage, no?
There was a problem hiding this comment.
Ah, I see. I guess it depends what people expect the filters to mean -- "show me data I've marked as stage=design or stage=existing" vs "show me unresolved issues at this stage". Could we get clarity from whoever originally asked for this? Or we could re-word these checkboxes.
|
Checkbox updated as discussed, and fixed the bug where the user could get into an impossible state (design stage, resolved yes). PTAL @Pete-Y-CS |
No description provided.