Lookup authority fields automatically #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dabreegster
commented
Aug 7, 2024
dabreegster
commented
- Make sure the autocomplete and auto-fill behavior feels natural
- Sanity check the lists
Pete-Y-CS
reviewed
Aug 14, 2024
| @@ -50,7 +50,7 @@ | |||
| <Select | |||
| label="Authority" | |||
| emptyOption | |||
| choices={pairs(authorities)} | |||
| choices={authorities.map(([a, x, y]) => [a, a])} | |||
There was a problem hiding this comment.
it's slightly more verbose but it might be nicer if it was
[a, x, y] -> [authority, combined_authority, region]
bit clearer imo`
Pete-Y-CS
approved these changes
Aug 14, 2024
|
Problem is, the list from Power BI does not match stuff in the Inspectorate Tracker. I'll send that file in chat |
|
Thanks, I'll clean up the var names later on. Moving to draft until the differing authority list problem is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.