Redo PMP and JAT map controls for creating objects #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demos: https://acteng.github.io/inspectorate_tools/map_edit_panels/route_check/problems_map and https://acteng.github.io/inspectorate_tools/map_edit_panels/route_check/jat_check
Previously we used a radio button that was hard to spot for controlling whether to create new criticals/conflicts and movements/arms. It was very easy to click the map and accidentally create a stray object unintentionally; we saw this several times in the UX studies.
This PR switches to a map panel that makes it more clear what mode the user is in. Note it's still possible to click or drag an existing object even in the "New xyz" mode, but this is harder to fix and maybe even reasonable behavior anyway.
Still would like some advice on improving the map panel styling to make it clear what the current tool is. We could iterate on that later if needed.