Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo PMP and JAT map controls for creating objects #73

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

dabreegster
Copy link
Collaborator

Demos: https://acteng.github.io/inspectorate_tools/map_edit_panels/route_check/problems_map and https://acteng.github.io/inspectorate_tools/map_edit_panels/route_check/jat_check

Previously we used a radio button that was hard to spot for controlling whether to create new criticals/conflicts and movements/arms. It was very easy to click the map and accidentally create a stray object unintentionally; we saw this several times in the UX studies.

This PR switches to a map panel that makes it more clear what mode the user is in. Note it's still possible to click or drag an existing object even in the "New xyz" mode, but this is harder to fix and maybe even reasonable behavior anyway.

Still would like some advice on improving the map panel styling to make it clear what the current tool is. We could iterate on that later if needed.

@@ -31,8 +31,8 @@
<style>
div {
position: absolute;
top: 20px;
left: 50px;
top: 100px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also got rid of the old geolocate and fullscreen controls, because they're not useful for us, and adjusted the geocoder position. I'm sure all this could be improved further when we move more controls into map panels (streetview, scheme context layer, basemap, etc)
image

@dabreegster dabreegster requested a review from Pete-Y-CS July 29, 2024 14:59
@dabreegster
Copy link
Collaborator Author

Have gotten some good feedback about this, so will merge and iterate tomorrow when more people are around. Thanks for review

@dabreegster dabreegster merged commit a9e9b28 into main Jul 29, 2024
1 check passed
@dabreegster dabreegster deleted the map_edit_panels branch July 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants