Simplify the SS sketches shown as a SB layer -- one layer, not split … #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Nov 19, 2024
There was a problem hiding this comment.
Mostly just some careful renaming here
Pete-Y-CS
reviewed
Nov 20, 2024
| let localName = "local_schemes"; | ||
| let localTitle = "Your schemes"; | ||
| let localShow = showHideLayer(localName); | ||
| $: [localColor, localLegend] = pickStyle("interventionType"); |
There was a problem hiding this comment.
Wondering about local legend: v2 will want to be rebased onto this and we may want to rethink the legend
There was a problem hiding this comment.
Yep, let's figure that out in #544. There's more changes to browse needed for v2, like updating the intervention popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by ATF/LCWIP.
#536, and following up to #541
Demo: https://acteng.github.io/atip/sb_ss_one_layer/browse.html
The filters for local schemes are simple:
