Include new funding programme and a total length in the browse page #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pete-Y-CS
approved these changes
Jan 4, 2024
Pete-Y-CS
reviewed
Jan 4, 2024
src/lib/browse/colors.ts
Outdated
| atf3: "#FF62DC", | ||
| atf4: "#FFD833", | ||
| // A qualitative set from colorbrewer2.org | ||
| funding_programmes: ["#66c2a5", "#fc8d62", "#8da0cb", "#e78ac3"], |
There was a problem hiding this comment.
Actually we may want 5 (When we've resolved data issues):
ATF2, ATF3, ATF4, ATF4e, LCWIP.
No?
There was a problem hiding this comment.
To make the final category broader, we could also say "Planned pipeline" so it's not tied to any particular process or timescale.
There was a problem hiding this comment.
Pete: Fixed, changed to 6 colors for more future-proofness.
Robin: Good point, https://github.com/acteng/atip-scheme-data/pull/11
dabreegster
force-pushed
the
browse_fixes
branch
from
47f244f to
1897067
Compare
|
Rebased and fixed comments, thanks for reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coloring by funding was a bit broken and not reactive to new cases like "ATF2 or ATF3" and "LCWIP". Also add a total length count to the
Showing 639 schemes (5,811 routes, 184 areas, 0 crossings, 147 other, with total LineString length of 6606.7 miles)checkbox, since it's maybe of interest. (But if it's just confusing, will remove)