New polygon snap tool #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Apr 27, 2023
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| // TODO Save this in the route | |||
| let avoidDoublingBack = false; | |||
| $: routeTool.setConfig({ | |||
| $: routeTool.setRouteConfig({ | |||
There was a problem hiding this comment.
Sliiight bug here. If we make a snapped area, then make a snapped route, avoid doubling back will be true from the last call, but the checkbox won't be ticked. I think we need to add a property to the output geojson feature to indicate this option and keep it synced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118
screencast.mp4
For now, the new tool is distinct from the previous freehand polygon tool. In the future, we could try to merge the two, allowing easy freehand points alongside snapping. But for now, it's too tough.
As a note, this was a super quick change to crank out, because TS had my back. I had one or two bugs (forgetting to glue something up) and the compiler told me. I'm very happy with the decision to use it.