Adding column rules #389
Adding column rules #389
Conversation
|
@fidian thanks for the PR, looks like the unit tests need to be updated too |
|
I have no idea how to fix the test. Probably something is wrong with the newly added rules, but I don't seem to be able to find it. I don't see how |
|
@fidian The issue seems to be that you're missing a |
src/rules.js
Outdated
| */ | ||
| { | ||
| 'type': 'pattern', | ||
| 'name': 'Colm', |
There was a problem hiding this comment.
name property should be an English-readable string that succinctly describes the rule, see other rules for examples
src/rules.js
Outdated
| }, | ||
| { | ||
| 'type': 'pattern', | ||
| 'id': 'Colmr', |
|
@fidian you still interested in getting this in? |
|
Yeah, I am still interested in getting this in. Without any mean intents, I have wondered the same of the atomizer maintainers. The changes were simple once @src-code pointed them out and anyone could have made it happen. Is this project mostly abandoned? I find it extremely valuable. |
|
Typically we review the code expecting the PR creator to update the code based on the review suggestions. We are still maintaining atomizer and use it at Yahoo today. The code base is stable and generally we will add new features as requirements arise. If you still want to get this in, please update the code based on @src-code suggestions. Thanks! |
|
I had updated the code before my comment. It's possible that you missed my
commit.
…On Sun, Aug 22, 2021, 21:52 Seth Bertalotto ***@***.***> wrote:
Typically we review the code expecting the PR creator to update the code
based on the review suggestions.
We are still maintaining atomizer and use it at Yahoo today. The code base
is stable and generally we will add new features as requirements arise.
If you still want to get this in, please update the code based on
@src-code <https://github.com/src-code> suggestions. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#389 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADISPBXZUZ3TIKNFNP6ZKLT6GZWRANCNFSM45FUAXHQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Ok I see the commit but the tests still need updating. You can follow how the other ones are done. |
|
I pushed a merge of the current master branch, but the tests all run for me. I don't know what to say because the tests all appear to work, even after running
|
|
@fidian this was published in 3.10.0 https://github.com/acss-io/atomizer/releases/tag/v3.10.0 |
Adds column CSS rules.
Closes #371