Skip to content

Commit

Permalink
[FIX] add --line_ending argument to avoid differences when running on…
Browse files Browse the repository at this point in the history
… windows or linux
  • Loading branch information
ramiadavid committed Nov 6, 2022
1 parent ab75edf commit 589b05f
Showing 1 changed file with 17 additions and 6 deletions.
23 changes: 17 additions & 6 deletions setuptools_odoo/get_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ def _get_requirements(
return sorted(requirements, key=lambda s: s.lower())


def _render(requirements, header, fp):
def _render(requirements, header, fp, newline):
if header:
print(header, file=fp)
print(header, file=fp, end=newline)
for requirement in requirements:
print(requirement, file=fp)
print(requirement, file=fp, end=newline)


def main(args=None):
Expand Down Expand Up @@ -122,16 +122,27 @@ def main(args=None):
"python external dependencies (default: false)"
),
)
parser.add_argument(
"--line_ending",
default="lf",
help="line ending, values: lf, cr, crlf (default: lf)",
)
args = parser.parse_args(args)
requirements = _get_requirements(
args.addons_dir, include_addons=args.include_addons
)
if args.line_ending == "cr":
newline = '\r'
elif args.line_ending == "crlf":
newline = '\r\n'
else:
newline = '\n'
if args.output == "-":
_render(requirements, args.header, sys.stdout)
_render(requirements, args.header, sys.stdout, newline)
else:
if os.path.exists(args.output) or requirements:
with open(args.output, "w") as fp:
_render(requirements, args.header, fp)
with open(args.output, "w", newline='') as fp:
_render(requirements, args.header, fp, newline)


if __name__ == "__main__":
Expand Down

0 comments on commit 589b05f

Please sign in to comment.