Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] add '--distinct-oca' flag to have a disinction for third party addons coming from OCA #9

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[IMP] add '--distinct-oca' flag to have a disinction for third party addons coming from OCA #9

merged 1 commit into from
Oct 16, 2024

Conversation

AnizR
Copy link
Collaborator

@AnizR AnizR commented Aug 7, 2024

fixes #2

determine if an addon is provided by OCA, and extract the OCA addons out of the "Third-party" category into their own category

Note that:

  • addons in merge request won't have OCA category
  • it needs a connection to work

sbidoul
sbidoul reviewed Aug 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sbidoul
sbidoul reviewed Aug 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AnizR AnizR force-pushed the zra-sort-deps-oca branch from fa55cd5 to 9cfa6a1 Compare August 24, 2024 08:55
@AnizR AnizR marked this pull request as draft August 26, 2024 07:37
AnizR
AnizR commented Aug 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AnizR AnizR marked this pull request as ready for review September 30, 2024 13:34
@AnizR
Copy link
Collaborator Author

AnizR commented Oct 1, 2024

@FrancoMaxime ping

FrancoMaxime
FrancoMaxime reviewed Oct 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AnizR AnizR force-pushed the zra-sort-deps-oca branch from f83ceac to 2347cf3 Compare October 1, 2024 16:37
@AnizR
Copy link
Collaborator Author

AnizR commented Oct 1, 2024

@lmignon ping

lmignon
lmignon approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT!!!

@sbidoul
Copy link
Member

sbidoul commented Oct 2, 2024

Now we just need a little test. In another PR, it's fine too.

@AnizR AnizR force-pushed the zra-sort-deps-oca branch from 90a3689 to b60fef3 Compare October 16, 2024 12:50
@AnizR
[IMP] add '--distinct-oca' flag to have a disinction for third party …
9fb267a 
…addons coming from OCA

Add missing dependency

[IMP] add in cahche: reset cache and oca category

[IMP] odoo_sort_manifes_depends: clean computation of category

[IMP] odoo-sort-manifest-depends: use platformdirs to set caching directory
@AnizR AnizR force-pushed the zra-sort-deps-oca branch from b60fef3 to 9fb267a Compare October 16, 2024 13:05
@AnizR
Copy link
Collaborator Author

AnizR commented Oct 16, 2024

Now we just need a little test. In another PR, it's fine too.

It is on my todo list, I'll do it in a different PR

@sbidoul sbidoul merged commit 4abad7c into master Oct 16, 2024
1 check passed
@sbidoul sbidoul deleted the zra-sort-deps-oca branch October 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul left review comments

@lmignon lmignon lmignon approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCA category
4 participants
@AnizR @sbidoul @lmignon @FrancoMaxime