Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --exclude-core-addons flag #53

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Feb 3, 2023

With this feature, together with --select-found, you can find all non-core addons automatically.

@moduon MT-1075

@yajo
Copy link
Contributor Author

yajo commented Feb 3, 2023

@sbidoul CI is broken... 😅

@yajo yajo changed the title feat: add --select-found flag feat: add --select-found and --exclude-core-addons flags Feb 3, 2023
@sbidoul
Copy link
Member

sbidoul commented Feb 3, 2023

One PR per feature, please.

@yajo yajo marked this pull request as draft February 3, 2023 12:05
@yajo yajo changed the title feat: add --select-found and --exclude-core-addons flags feat: add --exclude-core-addons flag Feb 3, 2023
@yajo
Copy link
Contributor Author

yajo commented Feb 3, 2023

OK, original PR is now in #54, and this one depends on it. I marked it as draft in the mean time.

(I do it like this to avoid having to rewrite the test, and also because I need to deploy both patches and it's easier for me to have both in the same branch).

tests/test_cmd_list.py Outdated Show resolved Hide resolved
@yajo yajo marked this pull request as ready for review February 3, 2023 13:02
@sbidoul
Copy link
Member

sbidoul commented Feb 3, 2023

Yeah, my point is that these features are logically independent, it's better to have a test for each individually.
But an integration may be useful too, as you prefer.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #53 (1915a3e) into main (a060a18) will increase coverage by 0.79%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   83.77%   84.57%   +0.79%     
==========================================
  Files          17       17              
  Lines         561      564       +3     
  Branches      114      115       +1     
==========================================
+ Hits          470      477       +7     
+ Misses         71       68       -3     
+ Partials       20       19       -1     
Impacted Files Coverage Δ
src/manifestoo/main.py 78.12% <60.00%> (+3.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yajo
Copy link
Contributor Author

yajo commented Feb 7, 2023

docs added

@sbidoul sbidoul merged commit 1cee5a0 into acsone:main Feb 7, 2023
@sbidoul
Copy link
Member

sbidoul commented Feb 7, 2023

Thanks!

@yajo yajo deleted the add-found branch February 9, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants