Various improvements to project template #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So ne need to ignore it, this simplifies gitlab-ci.yml a bit
- Workaround pypa/pip#9168 - --no-deps in editable install because the dep check has been done before
ThomasBinsfeld
approved these changes
Dec 3, 2020
| @@ -49,6 +48,7 @@ pre-commit: | |||
| script: | |||
| - install_pre_commit | |||
| - PRE_COMMIT_HOME=$PWD/.pre-commit ./pre-commit run --all-files | |||
| needs: [] | |||
Since we abandon pip install *.whl (due to a pip bug 9168), we can do the editable install in the same step with the same result.
ThomasBinsfeld
requested changes
Dec 9, 2020
| # although the project is part of *.whl, install it in editable mode so coverage sees it | ||
| - venv/bin/pip install --no-index -e . | ||
| # install the project in editable mode (-e) so coverage sees it | ||
| - venv/bin/pip install --no-index --find-links release -e odoo-addons-{{{ project.name }}} |
There was a problem hiding this comment.
Suggested change
| - venv/bin/pip install --no-index --find-links release -e odoo-addons-{{{ project.name }}} | |
| - venv/bin/pip install --no-index --find-links release -e . odoo-addons-{{{ project.name }}} |
There was a problem hiding this comment.
Indeed. And the project name is therefore not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly: