fix(CacheProvider): Exit early if cacheType based on blockNumber of RPC response is NONE #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PC response is NONE This [line](https://github.com/across-protocol/sdk/blob/80e2ab26b9dc68265d8d1707a3ee025e03cbc4dc/src/providers/cachedProvider.ts#L77) is triggering and throwing an error when an RPC request for a method like `eth_getTransactionReceipt` has an initial cache type of `DECIDE_TTL_POST_SEND` and then the RPC response reveals a `blockNumber` that is too close to HEAD. So the `cacheTypeForBlock` is returning `NONE` [here](https://github.com/across-protocol/sdk/blob/80e2ab26b9dc68265d8d1707a3ee025e03cbc4dc/src/providers/cachedProvider.ts#L174) which then throws an error when we try to set this RPC result in the cache
bmzig
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line is triggering and throwing an error when an RPC request for a method like
eth_getTransactionReceipthas an initial cache type ofDECIDE_TTL_POST_SENDand then the RPC response reveals ablockNumberthat is too close to HEAD.So the
cacheTypeForBlockis returningNONEhere which then throws an error when we try to set this RPC result in the cache