refactor: Remove SpokePoolClient oldestTime lookup #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `oldestTime` attribute is only needed for a very specific check when validating block ranges in the dataworker. Removing it from the standard SpokePoolClient update flow is a simplification for non-dataworker use-cases - i.e. relayer, monitor, finalizer. The dataworker can instead resolve the timestamp of the searchConfig fromBlock on demand. The underlying motivation for this change is to simplify the interface between the relayer and the external SpokePool listener processes.
pxrl
commented
Oct 16, 2024
pxrl
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
oldestTimeattribute is only needed for a very specific check when validating block ranges in the dataworker. Removing it from the standard SpokePoolClient update flow is a simplification for non-dataworker use-cases - i.e. relayer, monitor, finalizer. The dataworker can instead resolve the timestamp of the searchConfig fromBlock on demand.The underlying motivation for this change is to simplify the interface between the relayer and the external SpokePool listener processes in order to make way for additional updates.