chore: make async fn with no await an error #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
reviewed
Oct 3, 2023
| async getGasCosts(): Promise<BigNumberish> { | ||
| return gasCost(this.defaultGas, 1e9); // 1 gwei | ||
| getGasCosts(): Promise<BigNumberish> { | ||
| return Promise.resolve(gasCost(this.defaultGas, 1e9)); // 1 gwei |
There was a problem hiding this comment.
Why can't you just return gasCost if gasCost returns a Promise?
There was a problem hiding this comment.
gasCost unfortunately doesn't return a promise:
/**
* Convert a gas amount and gas price to wei.
*
* @param {number} gas - gas amount.
* @param {BigNumberish} gasPrice - gas price in gwei.
* @returns {BigNumber} - total fees in wei.
*/
export const gasCost = (gas: BigNumberish, gasPrice: BigNumberish): BigNumber => {
return BigNumber.from(gas).mul(gasPrice);
};
nicholaspai
approved these changes
Oct 3, 2023
james-a-morris
force-pushed
the
james/acx-1563-re-enable-some-validatefillts-tests
branch
from
eb57c59 to
4263e68
Compare
james-a-morris
changed the base branch from
james/acx-1563-re-enable-some-validatefillts-tests
to
master
nicholaspai
reviewed
Oct 3, 2023
package.json
Outdated
| @@ -19,8 +19,8 @@ | |||
| "build:types": "tsc --project tsconfig.build.json --module esnext --declarationDir ./dist/types --emitDeclarationOnly --declaration --declarationMap", | |||
| "test": "hardhat test", | |||
| "test:watch": "hardhat watch test", | |||
| "lint": "eslint --fix src", | |||
| "lint-check": "eslint src", | |||
| "lint": "eslint --fix src test", | |||
There was a problem hiding this comment.
side note: do you think we need to lint e2e also?
And do you think we should lint the hardhat.config.ts?
nicholaspai
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes floating promises an error in the SDK. There was a slight lift to convert non-async functions with the async tag into nonsync counterparts.
Going forward, the CI will tag these warnings as an error.