improve(ConfigStoreClient): Remove deprecated transferThreshold variable from config store #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
approved these changes
Sep 15, 2023
james-a-morris
approved these changes
Sep 16, 2023
nicholaspai
force-pushed
the
npai/transfer-threshold-removal
branch
from
03fcf2b to
d6e8ba8
Compare
pxrl
reviewed
Sep 19, 2023
package.json
Outdated
| "version": "0.15.22", | ||
| "version": "0.15.23", |
There was a problem hiding this comment.
This should probably be a bump in the minor, given that we're deprecating something.
src/interfaces/ConfigStore.ts
Outdated
| @@ -3,8 +3,7 @@ import { RateModelDictionary } from "../lpFeeCalculator/rateModel"; | |||
| import { SortableEvent } from "./Common"; | |||
|
|
|||
| export interface ParsedTokenConfig { | |||
| transferThreshold: string; | |||
| rateModel: RateModelDictionary; | |||
| rateModel: across.rateModel.RateModelDictionary; | |||
There was a problem hiding this comment.
I suspect this might be a bad merge - we don't import across from the UMA SDK anymore.
Suggested change
| rateModel: across.rateModel.RateModelDictionary; | |
| rateModel: RateModelDictionary; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream of across-protocol/relayer#937
Implements UMAprotocol/UMIPs#592