chore(eslint): Permit unused function arguments w/ _ prefix (#746)

across-protocol · Oct 1, 2024 · be49aef · be49aef
1 parent 6fe97c9
commit be49aef
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -39,7 +39,12 @@ module.exports = {
         ]
       }
     ],
-    "@typescript-eslint/no-unused-vars": ["error", { ignoreRestSiblings: true }],
+    "@typescript-eslint/no-unused-vars": [
+      "error", {
+        argsIgnorePattern: "^_",
+        ignoreRestSiblings: true
+      }
+    ],
     "chai-expect/missing-assertion": 2,
     "no-duplicate-imports": "error",
     "require-await": "error",

diff --git a/src/apiClient/mockedClient.ts b/src/apiClient/mockedClient.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unused-vars */
 import { ethers } from "ethers";
 import { deepCopy } from "ethers/lib/utils";
 import { BigNumber, bnOne } from "../utils";

diff --git a/src/clients/mocks/MockConfigStoreClient.ts b/src/clients/mocks/MockConfigStoreClient.ts
@@ -50,7 +50,6 @@ export class MockConfigStoreClient extends AcrossConfigStoreClient {
     return this.availableChainIdsOverride ?? super.getChainIdIndicesForBlock(block);
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   getConfigStoreVersionForBlock(_blockNumber: number): number {
     return this.configStoreVersion === DEFAULT_CONFIG_STORE_VERSION
       ? super.getConfigStoreVersionForBlock(_blockNumber)

diff --git a/src/relayFeeCalculator/relayFeeCalculator.ts b/src/relayFeeCalculator/relayFeeCalculator.ts
@@ -274,7 +274,6 @@ export class RelayFeeCalculator {
   }
 
   // Note: these variables are unused now, but may be needed in future versions of this function that are more complex.
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   capitalFeePercent(
     _amountToRelay: BigNumberish,
     _tokenSymbol: string,