fix: 🚑 resolve double stringify #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
requested review from
mrice32,
nicholaspai and
pxrl
as code owners
nicholaspai
approved these changes
Oct 12, 2023
mrice32
reviewed
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RedisCacheintroduced a doubleJSON.stringifyand aJSON.parseissue. These ran fine in an isolated environment becauseJSON.parse(JSON.parse(JSON.stringify(JSON.stringify(X))))will compute fine, but key/values clashed with our existing cache.This new hot fix removes the double
JSON.stringifyissue that was present with the merge of the latest PR.The cache should be cleared for good measure.
This was tested using a relayer iteration and a dataworker interation with a lookback of 16 bundles.