fix(validateRunningBalances): Change events we track to perform accounting #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nting Signed-off-by: nicholaspai <[email protected]>
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
james-a-morris
approved these changes
Oct 10, 2023
Comment on lines
+376
to
+377
| const excess = Number(excesses[0]); | ||
| return excess > 0.05 || excess < -0.05; |
There was a problem hiding this comment.
This may be problematic for the edge case that excesses[0] is too large. It would probably make sense to compare something like:
return excess.abs().gt(fromWei(0.05))
There was a problem hiding this comment.
excess is not a BN, its already been converted from one above
There was a problem hiding this comment.
Right, but why are we wrapping the excesses[0] string in Number? We could deal with it as a BN and prevent any overflow issues
|
Has this been broken for some time, or was this changed in more recent changes? We may want to run this on a fixed interval and flag it into Slack to catch this earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to script:
Signed-off-by: nicholaspai [email protected]