improve(relayer): Clear out token data explicitly and log token balances #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on an issue we're seeing where L1 to L2 rebalances are still getting duplicated, even after wrapping ETH, perhaps suggesting that the `tokenClient` is using stale data the logic written [here](https://github.com/across-protocol/relayer-v2/blob/master/src/relayer/RelayerClientHelper.ts#L159) should be reading updated balances post-ETH-unwrap but it may not. This PR adds more logs we can use to better debug
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
pxrl
approved these changes
Oct 10, 2023
src/clients/InventoryClient.ts
Outdated
Comment on lines
637
to
639
| if (!this.isInventoryManagementEnabled()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
What happens in this instance if there's no inventory config defined?
There was a problem hiding this comment.
hm yeah thanks for pressing on this, think this is what I wanted to do: 3d0678f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an issue we're seeing where L1 to L2 rebalances are still getting duplicated, even after wrapping ETH, perhaps suggesting that the
tokenClientis using stale datathe logic written here should be reading updated balances post-ETH-unwrap but it may not.
This PR adds more logs we can use to better debug