fix: handle early deposits #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <[email protected]>
mrice32
requested review from
nicholaspai,
pxrl and
james-a-morris
as code owners
Signed-off-by: Matt Rice <[email protected]>
This change imports from the correct directory rather than import from the dist directly.
james-a-morris
approved these changes
Sep 10, 2023
| chainIdListForBundleEvaluationBlockNumbers | ||
| ); | ||
| return (originClient["earlyDeposits"] as unknown as typechain.FundsDepositedEvent[]).filter( | ||
| (deposit: typechain.FundsDepositedEvent) => |
There was a problem hiding this comment.
Nit: with the typecast above, do we need to specify this function param?
There was a problem hiding this comment.
@james-a-morris maybe not, but just in the interest of time, let's do this in a follow-up.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.