improve: reduce errors in relayer tests #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
requested review from
mrice32,
nicholaspai and
pxrl
as code owners
mrice32
approved these changes
Sep 6, 2023
| @@ -729,7 +728,10 @@ describe("Dataworker: Load data used in all functions", async function () { | |||
| ); | |||
| const blockNumber = await spokePool_2.provider.getBlockNumber(); | |||
| const blockTimestamp = (await spokePool_2.provider.getBlock(blockNumber)).timestamp; | |||
| const realizedLpFeePctData = await hubPoolClient.computeRealizedLpFeePct(deposit1, l1Token_1.address); | |||
| const realizedLpFeePctData = await hubPoolClient.computeRealizedLpFeePct( | |||
| { ...deposit1, blockNumber }, | |||
There was a problem hiding this comment.
Is this a functional change?
There was a problem hiding this comment.
This PR is related to refactorings & slight rewrites to get the software to be able to compile with tsc.
Prior to this, we were having actual compiler errors due to signature incongruence on function/constructor calls.
|
@mrice32 resolving as we discussed offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.