improve(Relayer): Add total gas price to info log when relayer sends fill
#1949
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s fill This will help debugging and give us broad oversight into how accurate our gas price estimates are. We probably should refactor the overall relay fee calculation flow but this PR uses the data we already have (native and token gas costs) to derive the gas price easily. This PR also adds to the ProfitClient's `updateGasCosts` function a simple change to print out the gas price estimate per chain. A more helpful fix might be to add the `gasPrice` field to the `TransactionCostEstimate` type in the SDK and force functions like `sdk.common.estimateTotalGasRequiredByUnsignedTransaction()` to return the priority fee and base fee broken down so the relayer can log it
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
nicholaspai
commented
Dec 16, 2024
| this.totalGasCosts[destinationChainId] = await this._getTotalGasCost(deposit, relayer); | ||
| const { nativeGasCost, tokenGasCost } = await this._getTotalGasCost(deposit, relayer); | ||
| const gasPrice = tokenGasCost.div(nativeGasCost); | ||
| this.totalGasCosts[destinationChainId] = { |
There was a problem hiding this comment.
This adds the gas price estimate early in the relayer run to the ProfitClient's update function log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help debugging and give us broad oversight into how accurate our gas price estimates are. We probably should refactor the overall relay fee calculation flow but this PR uses the data we already have (native and token gas costs) to derive the gas price easily.
This PR also adds to the ProfitClient's
updateGasCostsfunction a simple change to print out the gas price estimate per chain.A more helpful fix might be to add the
gasPricefield to theTransactionCostEstimatetype in the SDK and force functions likesdk.common.estimateTotalGasRequiredByUnsignedTransaction()to return the priority fee and base fee broken down so the relayer can log it