Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make datadog logs more digestible in datadog #1937

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Dec 3, 2024

This PR makes a few modifications to the balance reports that are sent to datadog.

  1. It splits them into individual logs per balance. It is much easier for datadog to parse, filter, and groupBy if they are exported that way.
  2. It uses normal ethers formatting as opposed to our custom formatter. @james-a-morris pointed this out in the previous PR, but I misunderstood what he was saying. Thank you @james-a-morris!
  3. It uses datadog=true to export these logs rather than relying on a bespoke log sink.

Signed-off-by: Matt Rice <[email protected]>
@mrice32 mrice32 merged commit e393a92 into master Dec 5, 2024
4 checks passed
@mrice32 mrice32 deleted the mrice32/datadog-fix branch December 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants