chore: add return types

across-protocol · Sep 5, 2023 · f4a6500 · f4a6500
1 parent f566c24
commit f4a6500
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 12 deletions.
diff --git a/test/mocks/MockAdapterManager.ts b/test/mocks/MockAdapterManager.ts
@@ -11,7 +11,12 @@ export class MockAdapterManager extends AdapterManager {
   } = {};
 
   public mockedOutstandingCrossChainTransfers: { [chainId: number]: OutstandingTransfers } = {};
-  async sendTokenCrossChain(address: string, chainId: number, l1Token: string, amount: BigNumber) {
+  async sendTokenCrossChain(
+    _address: string,
+    chainId: number,
+    l1Token: string,
+    amount: BigNumber
+  ): Promise<TransactionResponse> {
     if (!this.tokensSentCrossChain[chainId]) {
       this.tokensSentCrossChain[chainId] = {};
     }
@@ -35,7 +40,7 @@ export class MockAdapterManager extends AdapterManager {
     return this.mockedOutstandingCrossChainTransfers[chainId];
   }
 
-  setMockedOutstandingCrossChainTransfers(chainId: number, address: string, l1Token: string, amount: BigNumber) {
+  setMockedOutstandingCrossChainTransfers(chainId: number, address: string, l1Token: string, amount: BigNumber): void {
     if (!this.mockedOutstandingCrossChainTransfers[chainId]) {
       this.mockedOutstandingCrossChainTransfers[chainId] = {};
     }

diff --git a/test/mocks/MockBundleDataClient.ts b/test/mocks/MockBundleDataClient.ts
@@ -5,19 +5,19 @@ export class MockBundleDataClient extends BundleDataClient {
   private pendingBundleRefunds: FillsToRefund = {};
   private nextBundleRefunds: FillsToRefund = {};
 
-  async getPendingRefundsFromValidBundles() {
+  async getPendingRefundsFromValidBundles(): Promise<FillsToRefund[]> {
     return [this.pendingBundleRefunds];
   }
 
-  async getNextBundleRefunds() {
+  async getNextBundleRefunds(): Promise<FillsToRefund> {
     return this.nextBundleRefunds;
   }
 
-  setReturnedPendingBundleRefunds(refunds: FillsToRefund) {
+  setReturnedPendingBundleRefunds(refunds: FillsToRefund): void {
     this.pendingBundleRefunds = refunds;
   }
 
-  setReturnedNextBundleRefunds(refunds: FillsToRefund) {
+  setReturnedNextBundleRefunds(refunds: FillsToRefund): void {
     this.nextBundleRefunds = refunds;
   }
 }
diff --git a/test/mocks/MockInventoryClient.ts b/test/mocks/MockInventoryClient.ts
@@ -5,7 +5,7 @@ export class MockInventoryClient extends InventoryClient {
     super(null, null, null, null, null, null, null, null, null);
   }
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  async determineRefundChainId(_deposit: Deposit) {
+  async determineRefundChainId(_deposit: Deposit): Promise<number> {
     return 1;
   }
 }
diff --git a/test/mocks/MockTokenClient.ts b/test/mocks/MockTokenClient.ts
@@ -8,20 +8,20 @@ export class MockTokenClient extends TokenClient {
     [chainId: number]: { [token: string]: { deposits: number[]; totalRequirement: BigNumber } };
   } = {};
 
-  setTokenData(chainId: number, token: string, balance: BigNumber, allowance: BigNumber = toBN(0)) {
+  setTokenData(chainId: number, token: string, balance: BigNumber, allowance: BigNumber = toBN(0)): void {
     if (!this.tokenData[chainId]) {
       this.tokenData[chainId] = {};
     }
     this.tokenData[chainId][token] = { balance, allowance };
   }
-  setTokenShortFallData(chainId: number, token: string, deposits: number[], totalRequirement: BigNumber) {
+  setTokenShortFallData(chainId: number, token: string, deposits: number[], totalRequirement: BigNumber): void {
     if (!this.tokenShortfall[chainId]) {
       this.tokenShortfall[chainId] = {};
     }
     this.tokenShortfall[chainId][token] = { deposits, totalRequirement };
   }
 
-  getBalance(chainId: number, token: string) {
+  getBalance(chainId: number, token: string): BigNumber {
     if (!this.tokenData[chainId]) {
       return toBN(0);
     }
@@ -31,7 +31,7 @@ export class MockTokenClient extends TokenClient {
     return this.tokenData[chainId][token].balance;
   }
 
-  getTokensNeededToCoverShortfall(chainId: number, token: string) {
+  getTokensNeededToCoverShortfall(chainId: number, token: string): BigNumber {
     if (!this.tokenShortfall[chainId]) {
       return toBN(0);
     }
@@ -41,7 +41,7 @@ export class MockTokenClient extends TokenClient {
     return this.tokenShortfall[chainId][token].totalRequirement;
   }
 
-  decrementLocalBalance(chainId: number, token: string, amount: BigNumber) {
+  decrementLocalBalance(chainId: number, token: string, amount: BigNumber): void {
     if (!this.tokenData[chainId]) {
       this.tokenData[chainId] = {};
     }