Skip to content

Commit

Permalink
Merge branch 'master' into james/acx-1528-prevent-unhandled-promises-…
Browse files Browse the repository at this point in the history
…from-being-called
  • Loading branch information
pxrl authored Sep 7, 2023
2 parents 137eb73 + 9b3f917 commit 87fbadd
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/utils/ProviderUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,15 @@ function compareRpcResults(method: string, rpcResultA: any, rpcResultB: any): bo
// JSON RPC spec: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getfilterchanges
// Additional reference: https://github.com/ethers-io/ethers.js/issues/1721
// 2023-08-31 Added blockHash because of upstream zkSync provider disagreements. Consider removing later.
return compareResultsAndFilterIgnoredKeys(["blockHash", "transactionLogIndex"], rpcResultA, rpcResultB);
return compareResultsAndFilterIgnoredKeys(
[
"l1BatchNumber", // zkSync
"l1BatchTimestamp", // zkSync
"transactionLogIndex",
],
rpcResultA,
rpcResultB
);
} else {
return lodash.isEqual(rpcResultA, rpcResultB);
}
Expand Down

0 comments on commit 87fbadd

Please sign in to comment.