Skip to content

Commit

Permalink
improve: leverage default TTL & leverage caching (#938)
Browse files Browse the repository at this point in the history
* improve: leverage default TTL

* improve: set fn signature to default
  • Loading branch information
james-a-morris authored Sep 16, 2023
1 parent e37ed76 commit 3b4c101
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@across-protocol/contracts-v2": "2.4.3",
"@across-protocol/sdk-v2": "0.15.21",
"@across-protocol/sdk-v2": "0.15.22",
"@arbitrum/sdk": "^3.1.3",
"@defi-wonderland/smock": "^2.3.5",
"@eth-optimism/sdk": "^3.1.0",
Expand Down
4 changes: 2 additions & 2 deletions src/caching/RedisCache.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { interfaces } from "@across-protocol/sdk-v2";
import { interfaces, constants } from "@across-protocol/sdk-v2";
import { RedisClient, getRedis, objectWithBigNumberReviver, setRedisKey, winston } from "../utils";

/**
Expand Down Expand Up @@ -61,7 +61,7 @@ export class RedisCache implements interfaces.CachingMechanismInterface {
}
}

public async set<T>(key: string, value: T, ttl?: number): Promise<string | undefined> {
public async set<T>(key: string, value: T, ttl: number = constants.DEFAULT_CACHING_TTL): Promise<string | undefined> {
// Instantiate the redis client if it has not been instantiated yet.
if (!this.redisClient) {
await this.instantiate();
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
"@openzeppelin/contracts" "4.1.0"
"@uma/core" "^2.18.0"

"@across-protocol/[email protected].21":
version "0.15.21"
resolved "https://registry.yarnpkg.com/@across-protocol/sdk-v2/-/sdk-v2-0.15.21.tgz#da6de385c36c947a724ea2e02fed455ba21c7605"
integrity sha512-+3cudHaDaPryjXIO/fRZ9J+VUE9pzS57ySMbxso0uxUYgNHX/rncaxza6KA/MPxr9yVraPbxgQGdxT38ZAmdcA==
"@across-protocol/[email protected].22":
version "0.15.22"
resolved "https://registry.yarnpkg.com/@across-protocol/sdk-v2/-/sdk-v2-0.15.22.tgz#a33c772005a781e1bf4492a32b7f41dae23d4051"
integrity sha512-EniItgtgTRvnjP/tWQze71F9+/uOqdg7IUugmaBhrJQ3heeySFDMgooJZGAgjmVJMrTfZXWKMaarDpy5nQAifg==
dependencies:
"@across-protocol/across-token" "^1.0.0"
"@across-protocol/contracts-v2" "^2.4.3"
Expand Down

0 comments on commit 3b4c101

Please sign in to comment.