Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate legacy fee response values #1307

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Dec 3, 2024

No description provided.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 3:04pm
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 3:04pm
sepolia-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 3:04pm

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we telegraph this to integrators?

gsteenkamp89
gsteenkamp89 previously approved these changes Dec 3, 2024
@dohaki
Copy link
Contributor Author

dohaki commented Dec 4, 2024

Should we telegraph this to integrators?

Yep in progress

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so it won't block. LGTM only when the integrators are ready

@dohaki dohaki merged commit 28dcea6 into master Feb 10, 2025
9 checks passed
@dohaki dohaki deleted the deprecate-legacy-fee-values branch February 10, 2025 04:59
dohaki added a commit that referenced this pull request Feb 10, 2025
dohaki added a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants