feat(svm): deploy solana adapter sepolia #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
commented
Feb 24, 2025
md0x
requested review from
mrice32,
nicholaspai,
pxrl and
bmzig
as code owners
Reinis-FRP
reviewed
Feb 25, 2025
deploy/063_deploy_solana_adapter.ts
Outdated
| }; | ||
|
|
||
| module.exports = func; | ||
| func.tags = ["Solana_Adapter"]; |
There was a problem hiding this comment.
nit: other adapter deployment scripts don't use underscores in their tag names and have additional mainnet tag
deploy/063_deploy_solana_adapter.ts
Outdated
Comment on lines
17
to
25
| const CCTP_TOKEN_MESSENGER_V1 = { | ||
| [CHAIN_IDs.MAINNET]: "0xbd3fa81b58ba92a82136038b25adec7066af3155", | ||
| [CHAIN_IDs.SEPOLIA]: "0x9f3B8679c73C2Fef8b59B4f3444d4e156fb70AA5", | ||
| }; | ||
|
|
||
| const CCTP_MESSAGE_TRANSMITTER_V1 = { | ||
| [CHAIN_IDs.MAINNET]: "0x0a992d191deec32afe36203ad87d7d289a738f81", | ||
| [CHAIN_IDs.SEPOLIA]: "0x7865fAfC2db2093669d92c0F33AeEF291086BEFD", | ||
| }; |
There was a problem hiding this comment.
We already have these under L1_ADDRESS_MAP in deploy/consts.ts
deploy/063_deploy_solana_adapter.ts
Outdated
Comment on lines
12
to
15
| const fromBase58 = (input: string) => { | ||
| const decodedBytes = utils.bytes.bs58.decode(input); | ||
| return "0x" + Buffer.from(decodedBytes).toString("hex"); | ||
| }; |
There was a problem hiding this comment.
this is duplicate of fromBase58ToBytes32 in src/svm/web3-v1/conversionUtils.ts
deploy/063_deploy_solana_adapter.ts
Outdated
| const solanaSpokePoolUsdcVault = fromBase58(vault.toBase58()); | ||
| const solanaSpokePoolBytes32 = fromBase58(solanaSpokePool); | ||
|
|
||
| await hre.deployments.deploy("Solana_Adapter", { |
There was a problem hiding this comment.
other adapters take the resulting instance and run contract verification task on it
Co-authored-by: Reinis Martinsons <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
…-protocol/contracts into pablo/deploy-solana-adapter
md0x
force-pushed
the
pablo/deploy-solana-adapter
branch
2 times, most recently
from
a9e215e to
1467679
Compare
Signed-off-by: Pablo Maldonado <[email protected]>
Reinis-FRP
approved these changes
Feb 27, 2025
chrismaree
reviewed
Mar 4, 2025
| @@ -178,5 +179,23 @@ | |||
| "130": { | |||
| "SpokePool": { "address": "0x09aea4b2242abC8bb4BB78D537A67a245A7bEC64", "blockNumber": 7915488 }, | |||
| "MulticallHandler": { "address": "0x924a9f036260DdD5808007E1AA95f08eD08aA569", "blockNumber": 7930191 } | |||
| }, | |||
| "133268194659241": { | |||
There was a problem hiding this comment.
this seems like its linted differently to the rest of this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: