feat(ink): configure and deploy Ink contracts #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmzig
reviewed
Dec 18, 2024
pxrl
reviewed
Dec 19, 2024
pxrl
reviewed
Dec 19, 2024
pxrl
reviewed
Dec 19, 2024
pxrl
reviewed
Dec 19, 2024
pxrl
reviewed
Dec 19, 2024
james-a-morris
force-pushed
the
james/acx-3455-deploy-contracts
branch
from
1b13aed to
52e60b1
Compare
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
force-pushed
the
james/acx-3455-deploy-contracts
branch
from
52e60b1 to
ed8842b
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
pxrl
reviewed
Dec 19, 2024
| {} // solhint-disable-line no-empty-blocks | ||
|
|
||
| /** | ||
| * @notice Construct the OVM World Chain SpokePool. |
There was a problem hiding this comment.
We should probably just drop any chain-specific mentions here; they just cause unnecessary changes on each deployment.
Suggested change
| * @notice Construct the OVM World Chain SpokePool. | |
| * @notice Construct the SpokePool. |
pxrl
reviewed
Dec 19, 2024
Comment on lines
+56
to
+57
| * @dev This implementation deviates slightly from `_bridgeTokensToHubPool` in the `Ovm_SpokePool` contract since World Chain has a USDC bridge which uses | ||
| * a custom interface. This is because the USDC token on World Chain is meant to be upgraded to a native, CCTP supported version in the future. |
There was a problem hiding this comment.
Suggested change
| * @dev This implementation deviates slightly from `_bridgeTokensToHubPool` in the `Ovm_SpokePool` contract since World Chain has a USDC bridge which uses | |
| * a custom interface. This is because the USDC token on World Chain is meant to be upgraded to a native, CCTP supported version in the future. | |
| * @dev This implementation deviates slightly from `_bridgeTokensToHubPool` in the `Ovm_SpokePool` contract since | |
| * this chain uses Circle's bridged (upgradable to native) USDC standard, which uses a custom interface. |
pxrl
reviewed
Dec 19, 2024
Comment on lines
+60
to
+62
| // Handle custom USDC bridge which doesn't conform to the standard bridge interface. In the future, CCTP may be used to bridge USDC to mainnet, in which | ||
| // case bridging logic is handled by the Ovm_SpokePool code. In the meantime, if CCTP is not enabled, then use the USDC bridge. Once CCTP is activated on | ||
| // WorldChain, this block of code will be unused. |
There was a problem hiding this comment.
Suggested change
| // Handle custom USDC bridge which doesn't conform to the standard bridge interface. In the future, CCTP may be used to bridge USDC to mainnet, in which | |
| // case bridging logic is handled by the Ovm_SpokePool code. In the meantime, if CCTP is not enabled, then use the USDC bridge. Once CCTP is activated on | |
| // WorldChain, this block of code will be unused. | |
| // Handle Circle's bridge for upgradable USDC, which doesn't conform to the standard OP bridge interface. In the future, CCTP may be used to bridge USDC to mainnet, in which | |
| // case bridging logic is handled by the Ovm_SpokePool code. In the meantime, if CCTP is not enabled, then use the USDC bridge. Once CCTP is activated on this chain, this block of code will be unused. |
pxrl
approved these changes
Dec 19, 2024
bmzig
approved these changes
Dec 19, 2024
Signed-off-by: james-a-morris <[email protected]>
pxrl
approved these changes
Dec 19, 2024
* feat: deploy ink multicallhandler --------- Signed-off-by: james-a-morris <[email protected]>
bmzig
approved these changes
Dec 19, 2024
Yep but also because this is a low prio contract to deploy and this will begin to block Alex/myself on the rest of the deployments |
nicholaspai
approved these changes
Dec 19, 2024
Signed-off-by: james-a-morris <[email protected]>
I looked at the deployment process and found it's more convoluted now due to a merge conflict. I was able to make a deployment here: https://explorer.inkonchain.com/address/0xB4A8d45647445EA9FC3E1058096142390683dBC2?tab=contract Here's a PR to add it: #814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All deployments made against origin commit hash
7f9ebb360c9bfcc9960a0226a92098fccc186ce8. Rebased against master with all deployments made.