feat: improve rust linting with prettier #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <[email protected]>
chrismaree
requested review from
md0x and
Reinis-FRP
and removed request for
md0x
Reinis-FRP
reviewed
Oct 25, 2024
package.json
Outdated
| "lint-fix": "yarn prettier --write && cargo fmt --all", | ||
| "prettier": "prettier .", | ||
| "lint-js": "yarn prettier --list-different **/*.js **/*.ts", | ||
| "lint-rust": "yarn prettier --list-different **/*.rs", |
There was a problem hiding this comment.
this is quite slow locally as it tries to lint all anchor expanded macros. maybe we limit this to programs?
Signed-off-by: chrismaree <[email protected]>
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Reinis-FRP
approved these changes
Oct 28, 2024
Signed-off-by: chrismaree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chrismaree [email protected]