fix: better seed usage and improve signer macro location #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
chrismaree
force-pushed
the
chrismaree/seed-improvement
branch
from
c04acc4 to
249bf4c
Compare
chrismaree
force-pushed
the
chrismaree/seed-improvement
branch
from
8ca2d38 to
10e0eef
Compare
chrismaree
changed the title
Reinis-FRP
reviewed
Oct 25, 2024
| @@ -45,6 +45,13 @@ pub fn initialize( | |||
| let state = &mut ctx.accounts.state; | |||
| state.owner = *ctx.accounts.signer.key; | |||
| state.seed = seed; // Set the seed in the state | |||
|
|
|||
| // Seed should only be used in tests to enable fresh state between deployments. In production always set to 0. | |||
| #[cfg(not(feature = "test"))] | |||
There was a problem hiding this comment.
maybe move it out to testable, similar how we call initialize_current_time below?
chrismaree
force-pushed
the
chrismaree/seed-improvement
branch
from
dc49436 to
78eb22a
Compare
Reinis-FRP
approved these changes
Oct 28, 2024
md0x
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stylistic and formatting improvement