feat(svm): relay root bundle event #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <[email protected]>
Reinis-FRP
reviewed
Oct 23, 2024
programs/svm-spoke/src/event.rs
Outdated
| @@ -23,6 +23,13 @@ pub struct EnabledDepositRoute { | |||
| pub enabled: bool, | |||
| } | |||
|
|
|||
| #[event] | |||
| pub struct RelayRootBundleEvent { | |||
There was a problem hiding this comment.
this is named RelayedRootBundle in EVM. Also the ordering is different (rootBundleId, relayerRefundRoot, slowRelayRoot)
| root_bundle_id: state.root_bundle_id, | ||
| }); | ||
|
|
||
| // Finally, increment the root bundle id |
There was a problem hiding this comment.
not directly related to this PR, but I think its confusing to have prop named root_bundle_id in state account. Instead it should be something to resemble number of relayed bundles or next_root_bundle_id - Maybe add this as TODO here
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
deleted the
pablo/acx-2922-instructionsadminrs-add-event-to-relay_root_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this PR: